fix: prevent HEAD requests from writing body in streamhandler#1113
fix: prevent HEAD requests from writing body in streamhandler#1113pankgeorg wants to merge 3 commits intoJuliaWeb:masterfrom
HEAD requests from writing body in streamhandler#1113Conversation
pankgeorg
changed the title
HEAD requests from writing body in streamhandler
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1113 +/- ##
==========================================
+ Coverage 82.70% 82.71% +0.01%
==========================================
Files 32 32
Lines 3053 3055 +2
==========================================
+ Hits 2525 2527 +2
Misses 528 528 ☔ View full report in Codecov by Sentry. |
quinnj
left a comment
quinnj
left a comment
There was a problem hiding this comment.
Hmmmm, yeah, this seems fine. I tried seeing if there was somewhere else we could enforce this (like startwrite or unsafe_write for Stream), but I think this fine. Mind adding a quick test and then we can merge?
| @testset "HEAD request without body" begin | ||
| sometext = "This is a big body that we don't want returned during a head" | ||
| handler = req -> begin | ||
| return HTTP.Response(200, [], sometext) | ||
| end | ||
| server = HTTP.serve!(handler; listenany=true) | ||
| port = HTTP.port(server) | ||
|
|
||
| response = HTTP.head("http://localhost:$port") | ||
| @test response.status == 200 | ||
| @test String(response.body) == "" | ||
|
|
||
| response = HTTP.get("http://localhost:$port") | ||
| @test response.status == 200 | ||
| @test String(response.body) == sometext | ||
|
|
||
| close(server) | ||
| end |
There was a problem hiding this comment.
The very interesting thing here is that this fails with
HEAD request without body: Error During Test at /home/pgeorgakopoulos/pluto/HTTP.jl/test/server.jl:316
Got exception outside of a @test
HTTP.RequestError:
HTTP.Request:
HTTP.Messages.Request:
"""
GET / HTTP/1.1
Host: localhost:8081
Accept: */*
User-Agent: HTTP.jl/1.10.0-rc1
Content-Length: 0
Accept-Encoding: gzip
"""Underlying error:
HTTP.Parsers.ParseError(:INVALID_STATUS_LINE, "2e\r")
...
caused by: TaskFailedException
nested task error: HTTP.Parsers.ParseError(:INVALID_STATUS_LINE, "2e\r")
...
caused by: HTTP.Parsers.ParseError(:INVALID_STATUS_LINE, "This is a big body that we don't want returnedHTTP/1.1 200 OK\r")
Stacktrace:
[1] parse_status_line!(bytes::String, response::HTTP.Messages.Response)
@ HTTP.Parsers ~/pluto/HTTP.jl/src/Parsers.jl:206
without this PR
There was a problem hiding this comment.
which is very similar to a request smuggling attack.
|
4 participants
(Note: if you're using your own
streamhandler, you're on your own)fixes: #1112
with this fix, 3 connections fly over the same connection with cURL